-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduced RenderWithOptions method, changed RenderTo signature; modi… #97
Conversation
As I made some changes in |
The main package should probably be tested independently without the dependency on subpackages -- since they are optional -- so I think |
elem.go
Outdated
@@ -53,16 +53,21 @@ var booleanAttrs = map[string]struct{}{ | |||
attrs.Selected: {}, | |||
} | |||
|
|||
type RenderOptions struct { | |||
DisablePreamble bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this comment above this line please? // DisablePreamble disables the doctype preamble for the HTML tag if it exists in the rendering tree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, since these options actually are present on any element calling Render
what do you think about being more specific with a name like DisableHtmlPreamble
, DisableDocumentPreamble
, or DisableDocPreamble
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DisableHtmlPreamble
looks pretty self-explanatory, as we call it for html
tag. Also added the comment.
…fied styles.CSS testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Draft for
RenderWithOptions
method, refers to #96