Merge pull request #198 from leighmcculloch/issue-197

Be resilient to unrecognized operation types
chatch · Feb 6, 2021 · 6f66b47 · 6f66b47
2 parents 27d7e48 + 7e3f163
commit 6f66b47
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 1 deletion.
diff --git a/src/components/operations/Operation.js b/src/components/operations/Operation.js
@@ -18,6 +18,7 @@ import Offer from './Offer'
 import PathPayment from './PathPayment'
 import Payment from './Payment'
 import SetOptions from './SetOptions'
+import Unrecognized from './Unrecognized'
 
 const opTypeComponentMap = {
   account_merge: AccountMerge,
@@ -47,7 +48,7 @@ const opTypeComponentMap = {
 const opTypes = Object.keys(opTypeComponentMap)
 
 const SubOperation = ({op}) => {
-  const SubOpComponent = opTypeComponentMap[op.type]
+  const SubOpComponent = opTypeComponentMap[op.type] || Unrecognized
   return <SubOpComponent {...op} />
 }
 

diff --git a/src/components/operations/Unrecognized.js b/src/components/operations/Unrecognized.js
@@ -0,0 +1,11 @@
+import React from 'react'
+import {FormattedMessage} from 'react-intl'
+
+const Unrecognized = ({type}) => <FormattedMessage
+  id="operation.unrecognized"
+  values={{
+    type: type,
+  }}
+/>
+
+export default Unrecognized
diff --git a/src/languages/en.json b/src/languages/en.json
@@ -134,6 +134,7 @@
   "operation.trust": "Trust {trustee} issuing {assetCode}",
   "operation.trust.allow": " [authorize: {authorize}, trustor: {trustor}]",
   "operation.trust.change": " with limit {limit}",
+  "operation.unrecognized": "Operation {type}",
 
   "optional": "Optional",
   "order.amount": "Amount",

diff --git a/src/languages/ru.json b/src/languages/ru.json
@@ -98,6 +98,7 @@
   "operation.trust": "Доверие {trustee} выпускающему {assetCode}",
   "operation.trust.allow": " [authorize: {authorize}, trustor: {trustor}]",
   "operation.trust.change": " с лимитом {limit}",
+  "operation.unregoznied": "Операция {type}",
 
   "optional": "Необязательно",
   "order.amount": "Сумма",

diff --git a/src/languages/vi.json b/src/languages/vi.json
@@ -97,6 +97,7 @@
   "operation.trust": "Tin tưởng {trustee} phát hành {assetCode}",
   "operation.trust.allow": " [authorize: {authorize}, trustor: {trustor}]",
   "operation.trust.change": " với giới hạn {limit}",
+  "operation.unregoznied": "Hoạt động {type}",
 
   "optional": "Không bắt buộc",
   "order.amount": "Số tiền",

diff --git a/src/languages/zh.json b/src/languages/zh.json
@@ -130,6 +130,7 @@
   "operation.trust": "信任 {trustee} 发行 {assetCode}",
   "operation.trust.allow": " [authorize: {authorize}, trustor: {trustor}]",
   "operation.trust.change": "至限额 {limit}",
+  "operation.unregoznied": "操作 {type}",
 
   "optional": "可选",
   "order.amount": "数量",