Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove max_smtp_rcpt_to, strict_tls from valid top-level keys and fix README.md accordingly (#285) #286

Merged
merged 1 commit into from
Mar 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ domains:
- an_array
- of_domains
- used_by_this_provider
opt:
max_smtp_rcpt_to: [optional: default is 50]
strict_tls: [optional: default is true]
server:
# Repeat the following block for each server (usually one for imap, one for smtp).
# If no servers are defined, autoconfig, autodiscover or guessing is used;
Expand All @@ -42,7 +45,6 @@ config_defaults:
# optional, see below for details
key: value
other_key: other_value
strict_tls: [optional: default is true]
last_checked: [optional: date when the information was last checked: YYYY-MM]
skip_auto_test: [optional: skip the provider in the automated tests. default is false]
website: [optional: website of the provider]
Expand Down Expand Up @@ -124,7 +126,7 @@ All other options are applied as usual.

## limit RCPT TO header

With the optional top-level option `max_smtp_rcpt_to=MAX`
With the `opt` option `max_smtp_rcpt_to: MAX`
you can set the maximum number of recipients
that should be used in an `RCPT TO:` smtp header.
If a message needs to be sent to more recipients,
Expand All @@ -140,7 +142,7 @@ If this limit is not specified, the library picks an reasonable default.
By default, all providers in to the provider-database
are assumed to support "Strict TLS".
If that is not true for a specific provider,
you have to add the optional top-level option `strict_tls: false`.
you have to add the `opt` option `strict_tls: false`.

Connections with `socket: PLAIN` are not affected by the `strict_tls` option,
it's not ignored, there is just no TLS at all.
1 change: 0 additions & 1 deletion _providers/daleth.cafe.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ server:
hostname: daleth.cafe
port: 587
username_pattern: EMAIL
strict_tls: true
last_checked: 2024-02
skip_auto_test: false
website: https://nein.jetzt
Expand Down
1 change: 0 additions & 1 deletion _providers/mehl.cloud.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ server:
hostname: mehl.cloud
port: 587
username_pattern: EMAIL
strict_tls: true
last_checked: 2024-02
skip_auto_test: false
website: https://nein.jetzt
Expand Down
2 changes: 0 additions & 2 deletions validation/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,11 @@ function test(fileContent) {
'config_defaults',
'domains',
'last_checked',
'max_smtp_rcpt_to',
'name',
'oauth2',
'opt',
'server',
'status',
'strict_tls',
'skip_auto_test',
'website',
].includes(key)) {
Expand Down
Loading