Basic modernizations #5
Conversation
When using CrateDB 3.2, the test case fails with: SystemExit: CrateDB didn't start in time or couldn't form a cluster. ERROR: Unrecognized VM option 'UseConcMarkSweepGC'
.github/workflows/main.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| os: ["ubuntu-20.04"] | ||
| python-version: ["3.6", "3.11"] |
There was a problem hiding this comment.
I've deliberately selected only the lower and upper bound of Python versions to be tested on, to save resources, and because I think it is safe enough for this kind of project. Please let me know if you want this to be expanded to enumerate all Python versions instead.
.github/workflows/main.yml
Outdated
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v3 | ||
| with: | ||
| files: ./coverage.xml | ||
| flags: unittests | ||
| env_vars: OS,PYTHON | ||
| name: codecov-umbrella | ||
| fail_ci_if_error: false |
There was a problem hiding this comment.
The repository would need to be added to https://codecov.io/ to make this work. In the meanwhile, fail_ci_if_error: false makes it so that it doesn't fail. Let me know if you have any objections about it.
| "Development Status :: 3 - Alpha", | ||
| "Development Status :: 4 - Beta", |
There was a problem hiding this comment.
The package is constantly used on a few projects, so I think it deserves to get the "Beta" status, at least ;], or even a higher ranking.
| yield from crate_layer("crate_a", "3.2.x") | ||
| yield from crate_layer("crate_a", "5.4.x") |
There was a problem hiding this comment.
FYI: When using CrateDB 3.2 today, the test case fails with:
ERROR: Unrecognized VM option 'UseConcMarkSweepGC'
SystemExit: CrateDB didn't start in time or couldn't form a cluster.
It is probably related to a more recent version of cr8, which does not have the capacity to invoke older versions of CrateDB? Should we take care about it in one way or another?
/cc @mfussenegger, @seut
|
Dear @chaudum, first of all, I would like to wish you a happy new year. If you have some spare minutes, may I humbly ask you to have a look at this patch? With kind regards, |
|
Dear @chaudum, we are adding a summary presenting possible test layer implementations over here, which is also including pytest-crate.
While doing that, we also submitted maintenance patches to the other upstream package this subsystem is building upon, cr8.
In this spirit, we would like to submit similar maintenance patches here, in order to keep the package up to speed with the progress induced by the environment. Do you think you could occasionally review our patches, and bring them into mainline, unless there are objections about them? With kind regards, |
amotl
force-pushed
the
modernize-basic
branch
3 times, most recently
from
e486d2e to
2c6698c
Compare
ModuleNotFoundError: No module named 'pkg_resources.extern'
|
FYI: This and other modernizations have been included in pytest-cratedb 0.4.0, now on PyPI. |
Dear Christian,
first things first: Thanks a stack for conceiving the
pytest-cratepackage.This patch adjusts the package dependencies and project metadata to make the software tests work on Python 3.6 to Python 3.11. It also migrates from Travis CI to GHA, demonstrated successfully at 1.
There are still a few deprecation warnings around, which can be addressed on behalf of a subsequent patch. Other than this, a few more versions of development packages can be updated, now in a more controlled manner. Dependabot will tell us about it.
With kind regards,
Andreas.
Footnotes
https://github.com/crate-workbench/pytest-crate/actions/runs/6634428546 ↩