Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn into ESM #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Turn into ESM #11

wants to merge 1 commit into from

Conversation

fregante
Copy link

@fregante fregante commented Aug 2, 2024

fregante
fregante commented Aug 2, 2024
View reviewed changes
package.json
@@ -70,6 +71,6 @@
"terser": "^5.10.0",
"ts-jest": "^27.1.2",
"ts-node": "^10.4.0",
"typescript": "^4.5.4"
"typescript": "^5.5.4"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I avoided upgrading the rest of the dependencies because there were issues in your shared config

package.json
@@ -7,7 +7,7 @@
"repository": "cheap-glitch/mi-cron",
"homepage": "https://github.com/cheap-glitch/mi-cron#readme",
"bugs": "https://github.com/cheap-glitch/mi-cron/issues",
"funding": "https://github.com/sponsors/cheap-glitch",
"type": "module",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change, requires a new semver major

@fregante
Copy link
Author

ping @cheap-glitch

@fregante
Copy link
Author

For now: https://github.com/fregante/mi-cron#installation

npm rm @cheap-glitch/mi-cron
npm i @fregante/mi-cron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn into native ES module
1 participant
@fregante