feat: case name templating #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ChibiBlasphem
commented
Jan 6, 2025
ChibiBlasphem
commented
- Added new StringTemplate AST Node
- Let user update the case name template on workflow page
ChibiBlasphem
force-pushed
the
christopher/case-name-templating
branch
from
08e9b17 to
bc50100
Compare
Pascal-Delange
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
This one will have significant (but manageable) conflict with my refactor PR #643, but you go ahead and merge it first.
packages/app-builder/src/components/Scenario/Workflow/DetailPanel/CaseNameEditor.hook.ts
Outdated
Show resolved
Hide resolved
...derNode/Operand/OperandEditor/OperandEditModal/StringTemplateEdit/StringTemplateEdit.hook.ts
Outdated
Show resolved
Hide resolved
Pascal-Delange
approved these changes
Jan 7, 2025
| type: string | ||
| enum: ['string', 'int', 'float', 'bool', 'datetime'] |
There was a problem hiding this comment.
just a comment: I prefer "timestamp" to "datetime" here because that is what is actually manipulated in the backend, but this is in no way blocking for this feature so feel free to not make the change now
There was a problem hiding this comment.
i'll remove it from the enum list as for now we do not use it, changing it to timestamp would mean changing the backend and I already merged the PR on this side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.