Add from_image support #291
Conversation
|
One manual test before we merge this. Can you check through the console and make sure the |
| @@ -52,6 +52,29 @@ | |||
| source_dest_check: false | |||
| ).and be_idempotent | |||
| end | |||
|
|
|||
| it "machine with from_image option is created from correct image", :super_slow do | |||
There was a problem hiding this comment.
Will you actually pull this into its own machine_image.rb spec file?
There was a problem hiding this comment.
Why? It belongs to machine resource => machine spec
There was a problem hiding this comment.
oh derp, you're totally right - we're testing the machine from_image spec. Going to get more coffee now!
|
Hmm, nope, test_image_ami was not removed. How can I do it? |
|
@tyler-ball Nevermind, I figured it out. Now it removes AMI after test as expected. |
| end | ||
| }.to create_an_aws_instance('test_machine', | ||
| image_id: driver.ec2.images.filter('name', 'test_machine_ami').first.image_id | ||
| ).and create_an_aws_image('test_machine_ami', |
There was a problem hiding this comment.
Perfect! Excellent troubleshooting
|
Thanks for the awesome work @Fodoj ! |
|
Thanks for reviewing and merging this stuff 👍 |
tas50
added
Type: Enhancement
tas50
added
Triage: Needs Information
Previously
from_imageimplementation was missing. After this fix chef-boneyard/chef-provisioning#366 this implementation is possible now.Fixes #193
@tyler-ball please take a look. Spec is green, I've also tested manually :) Would love to see it merged and 1.4 released soon.