Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic vpc for elb #445

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

bbbco
Copy link
Contributor

@bbbco bbbco commented Feb 2, 2016

We need to be able to support Classic VPC within our organization, and so this pull request does just that in regards to ELBs.

@tyler-ball
Copy link
Contributor

Hey @bbbco - I was looking to manually test this one during the August 31st office hours and ran into a bunch of gem compilation errors. I'm going to table this one and put it to the top of my queue for next week. Thanks for the PR and I look forward to getting it in after some testing!

Ideally I would like to add actual tests but any time I tried to do that in the past with EC2 classic setup I was not able to. Any chance you were able to get that working?

@bbbco
Copy link
Contributor Author

bbbco commented Aug 31, 2016

http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-supported-platforms.html
http://docs.rightscale.com/faq/clouds/aws/What_is_an_EC2-Classic_network.html

It looks like EC2 Classic is no longer available to new accounts. I'm guessing that your EC2 credentials only permit VPC. There are instructions on the AWS page on how you can check to verify this.

My organization uses Classic EC2 by default, and so we use this fix to provision our AWS nodes and use Classic ELBs.

What would you like to do about the tests?

@bbbco
Copy link
Contributor Author

bbbco commented Oct 31, 2016

Haven't heard anything back about this @tyler-ball ... any other input?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants