aws_rds_instance - update to support modify, and wait for create #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t point we can start using the instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Incomplete due to changes in master, but otherwise working for me in an older fork.
Previously, rds was create-only, no modifications would apply. this adds logic to handle update. Also added options around waiting for update/create/delete to complete, and logic to wait for create.
Note that updates (modify) are -always- run on every convergence, because we cannot sanely compare current to desired state. In reality, this means that the master password is 'updated' every run - but no other state changes actually apply unless they need to.
Users will definitely want to review their
additional_options( apply_immediately: ... )state - this defaults to applying during the maint window.