Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform Upgrade in Automate HA #8253

Merged
merged 10 commits into from
Oct 25, 2023
Merged

Terraform Upgrade in Automate HA #8253

merged 10 commits into from
Oct 25, 2023

Conversation

schaudha
Copy link
Collaborator

@schaudha schaudha commented Oct 10, 2023

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-7297

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

@schaudha schaudha requested a review from a team as a code owner October 10, 2023 12:40
@netlify
Copy link

netlify bot commented Oct 10, 2023

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 1a6c74f
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6538fcf658e8ad00097b0fe3

Copy link
Collaborator

@punitmundra punitmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason these certificate got regenerated ?

Copy link
Collaborator

@punitmundra punitmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schaudha : can you remove the other change which are not the part of terrform upgrade

Copy link
Collaborator

@ArvinthC3000 ArvinthC3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase the branch with main

@github-actions github-actions bot removed the documentation Anything related to the Automate docs. label Oct 12, 2023
Signed-off-by: Sushil Chaudhari <[email protected]>
Signed-off-by: Sushil Chaudhari <[email protected]>
@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Signed-off-by: Sushil Chaudhari <[email protected]>
@punitmundra punitmundra merged commit 46ce68a into main Oct 25, 2023
@punitmundra punitmundra deleted the tf_upgrade_sushil branch October 25, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants