Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config 'track_total_hits' for patching in embedded-CS for Erchef #8699

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

talktovikas
Copy link
Collaborator

@talktovikas talktovikas commented Dec 17, 2024

🔩 Description: What code changed, and why?

We have added track_total_hits field in CS indexing, Now users can patch this config in embedded CS also.
This pr contains changes for that.
JIRA TICKET: https://progresssoftware.atlassian.net/browse/CHEF-5783

⛓️ Related Resources

👍 Definition of Done

Demo Video for this: https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/ER7ArTDUvsVNmUHhZ7siOGQB2XCFTRwfRgV5Ft-M22SFFA?e=BdOf35

👟 How to Build and Test the Change

user can use this

[erchef.v1.sys.index]
 track_total_hits=true

can be patched like this

chef-automate config patch test.toml

changes will reflect here.

sudo nano /hab/svc/automate-cs-oc-erchef/config/sys.config

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@talktovikas talktovikas requested a review from a team as a code owner December 17, 2024 07:33
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 91aa859
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6764133c647f3200081bd840

@talktovikas
Copy link
Collaborator Author

DOC changes View:
Screenshot 2024-12-17 at 1 13 38 PM

@talktovikas talktovikas force-pushed the vikas/indexing_config branch from 6583c44 to 91aa859 Compare December 19, 2024 12:36

@Dmaddu Dmaddu merged commit f273736 into main Dec 23, 2024
11 of 13 checks passed
@Dmaddu Dmaddu deleted the vikas/indexing_config branch December 23, 2024 08:10
@talktovikas
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants