Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubyracer fixing for verify pipeline. #3787

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

sreepuramsudheer
Copy link
Contributor

Description

[Please describe what this change achieves]

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]

Check List

@sreepuramsudheer sreepuramsudheer requested review from a team as code owners March 4, 2024 06:13
Copy link

netlify bot commented Mar 4, 2024

👷 Deploy Preview for chef-server processing.

Name Link
🔨 Latest commit e0fe83d
🔍 Latest deploy log https://app.netlify.com/sites/chef-server/deploys/65e9d6424097f60008e6a646

@sreepuramsudheer sreepuramsudheer force-pushed the ssudheer/rubyracer_fix branch from 8db4c34 to dfc339b Compare March 4, 2024 06:23
@sreepuramsudheer
Copy link
Contributor Author

sreepuramsudheer commented Mar 4, 2024

@sreepuramsudheer sreepuramsudheer force-pushed the ssudheer/rubyracer_fix branch 5 times, most recently from a05ff90 to 0b9c16d Compare March 6, 2024 09:38
@@ -25,7 +25,8 @@ if [[ "${BUILDKITE:-false}" == "true" ]]; then
apt-get clean
apt-get autoremove
apt-get update
apt-get install -y libpq-dev libsqlite3-dev
apt-get install -y libpq-dev libsqlite3-dev libyaml-dev
gem info psych
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

@sreepuramsudheer sreepuramsudheer force-pushed the ssudheer/rubyracer_fix branch 3 times, most recently from ab9f52d to 7df2992 Compare March 7, 2024 14:22
Added step to install bundler 2.2.4.

Remove v8 and rubyracer

There doesn't seem to be any use of that library in OC-ID or its tests,
so let's see how it behaves without it.

Changes in oc-chef-pedent rake file to fix verify pipeline issue.

Signed-off-by: Marc A. Paradise <[email protected]>

Signed-off-by: sreepuramsudheer <[email protected]>

Signed-off-by: jan shahid shaik <[email protected]>
@sreepuramsudheer sreepuramsudheer force-pushed the ssudheer/rubyracer_fix branch from 7df2992 to e0fe83d Compare March 7, 2024 14:59
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sreepuramsudheer sreepuramsudheer merged commit 5172540 into main Mar 7, 2024
7 of 10 checks passed
@sreepuramsudheer sreepuramsudheer deleted the ssudheer/rubyracer_fix branch March 7, 2024 15:01

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants