-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubyracer fixing for verify pipeline. #3787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-server processing.
|
sreepuramsudheer
force-pushed
the
ssudheer/rubyracer_fix
branch
from
March 4, 2024 06:23
8db4c34
to
dfc339b
Compare
sreepuramsudheer
force-pushed
the
ssudheer/rubyracer_fix
branch
5 times, most recently
from
March 6, 2024 09:38
a05ff90
to
0b9c16d
Compare
jashaik
reviewed
Mar 7, 2024
.expeditor/license_scout.sh
Outdated
@@ -25,7 +25,8 @@ if [[ "${BUILDKITE:-false}" == "true" ]]; then | |||
apt-get clean | |||
apt-get autoremove | |||
apt-get update | |||
apt-get install -y libpq-dev libsqlite3-dev | |||
apt-get install -y libpq-dev libsqlite3-dev libyaml-dev | |||
gem info psych |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove
jashaik
approved these changes
Mar 7, 2024
sreepuramsudheer
force-pushed
the
ssudheer/rubyracer_fix
branch
3 times, most recently
from
March 7, 2024 14:22
ab9f52d
to
7df2992
Compare
Added step to install bundler 2.2.4. Remove v8 and rubyracer There doesn't seem to be any use of that library in OC-ID or its tests, so let's see how it behaves without it. Changes in oc-chef-pedent rake file to fix verify pipeline issue. Signed-off-by: Marc A. Paradise <[email protected]> Signed-off-by: sreepuramsudheer <[email protected]> Signed-off-by: jan shahid shaik <[email protected]>
sreepuramsudheer
force-pushed
the
ssudheer/rubyracer_fix
branch
from
March 7, 2024 14:59
7df2992
to
e0fe83d
Compare
Quality Gate passedIssues Measures |
SonarQube Quality Gate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Please describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List