WIP: Initial draft of telemetry #3822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreepuramsudheer
changed the title
👷 Deploy Preview for chef-server processing.
|
sreepuramsudheer
force-pushed
the
ssudheer/CHEF-12629
branch
2 times, most recently
from
da9ff9e to
3096fa3
Compare
Signed-off-by: sreepuramsudheer <[email protected]>
sreepuramsudheer
force-pushed
the
ssudheer/CHEF-12629
branch
from
3096fa3 to
572384a
Compare
|
|
SonarQube Quality Gate
|
jashaik
reviewed
Jul 10, 2024
|
|
||
| -spec token() -> string() | atom(). | ||
| token() -> | ||
| case chef_secrets:get(<<"data_collector">>, <<"token">>) of |
There was a problem hiding this comment.
Why are we using data_collector token in telemetry ?
jashaik
reviewed
Jul 10, 2024
|
|
||
| -spec is_enabled() -> boolean(). | ||
| is_enabled() -> | ||
| case application:get_env(chef_telemetry, root_url) of |
There was a problem hiding this comment.
Are we handling empty string cases/invalid url cases ?
Do we need to include this telemetry status in health api ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Please describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List