Undefine allocation function for C extension class #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tpowell-progress Could you review this? This squashes an annoying warning showing up with Ruby 3.2 and up. 😄 |
Ruby 3.2 adds a new warning is printed when a Ruby class created in a C extension does not specify an allocate function or undefine it: ``` warning: undefining the allocator of T_DATA class FFI_Yajl::Ext::Encoder::YajlGen ``` As described in https://bugs.ruby-lang.org/issues/18007 and https://github.com/ruby/ruby/blob/7317f96727725ca37ddb06011918deb841de371c/doc/extension.rdoc#label-Write+the+C+Code, we only need to define an allocate function if the class uses a C struct and stores any values on it. Closes chef#123 Signed-off-by: Stan Hu <[email protected]>
stanhu
force-pushed
the
sh-fix-ruby-t-data-warning
branch
from
fe837bd to
be9ee74
Compare
tpowell-progress
approved these changes
Feb 6, 2025
|
@stanhu I may have to request a rebase to fix tests. Opening a PR to drop 2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.2 adds a new warning is printed when a Ruby class created in a C extension does not specify an allocate function or undefine it:
As described in https://bugs.ruby-lang.org/issues/18007 and https://github.com/ruby/ruby/blob/7317f96727725ca37ddb06011918deb841de371c/doc/extension.rdoc#label-Write+the+C+Code, we only need to define an allocate function if the class uses a C struct and stores any values on it.
Closes #123
Description
[Please describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List