Fix warning: Kernel#open is deprecated

Opening URIs by redirecting through Kernel#open is deprecated as of Ruby 2.7 and is dropped in Ruby 3.0. To unblock applications that use Ruby 3, we need to replace these calls with URI.open. Cf.: https://rubyreferences.github.io/rubychanges/2.7.html#network-and-web ruby/open-uri@53862fa Signed-off-by: Matthias Kaeppler <[email protected]>
chef · Jul 15, 2021 · e61f685 · e61f685
1 parent 1886f1c
commit e61f685
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 5 deletions.
diff --git a/lib/license_scout/license.rb b/lib/license_scout/license.rb
@@ -106,7 +106,7 @@ def license_content(license_id, contents_url)
 
         begin
           LicenseScout::Log.debug("[license] Pulling license content for #{license_id} from #{new_url}")
-          open(new_url).read
+          URI.open(new_url).read
         rescue RuntimeError => e
           if e.message =~ /redirection forbidden/
             m = /redirection forbidden:\s+(.+)\s+->\s+(.+)/.match(e.message)

diff --git a/spec/license_scout/license_spec.rb b/spec/license_scout/license_spec.rb
@@ -27,13 +27,13 @@
   let(:apache_license_content) { File.read(File.join(SPEC_FIXTURES_DIR, "empty_project", "LICENSE")) }
   let(:record) { described_class::Record.new(spdx, source, apache_license_content) }
 
-  before do
-    allow(described_class::Record).to receive(:new).with(spdx, source, apache_license_content).and_return(record)
-  end
-
   describe ".new" do
     let(:subject) { described_class.new(dependency_path) }
 
+    before do
+      allow(described_class::Record).to receive(:new).with(spdx, source, apache_license_content).and_return(record)
+    end
+
     context "when path is nil" do
       let(:dependency_path) { nil }
 
@@ -91,4 +91,23 @@
       it { is_expected.to be false }
     end
   end
+
+  describe "#add_license" do
+    let(:license_url) { "https://url/to/license" }
+    let(:options) { { a: 42 } }
+
+    subject { described_class.new(dependency_path) }
+
+    it "downloads license body and adds a new record" do
+      expect(URI).to receive(:open).with(license_url).and_return(StringIO.new(apache_license_content))
+
+      subject.add_license(spdx, source, license_url, options)
+
+      new_record = subject.records.last
+      expect(new_record).not_to be_nil
+      expect(new_record.id).to eq(spdx)
+      expect(new_record.source).to eq(source)
+      expect(new_record.content).to eq(apache_license_content)
+    end
+  end
 end