-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to extend the supported products of mixlib-install #340
Conversation
ea88532
to
e977bbf
Compare
@chef/chef-foundation-owners Something I should do on this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, we have agreement on the approach here, but @Tensibai you need to rebase here...
Signed-off-by: Tensibai <[email protected]>
e977bbf
to
eff6c44
Compare
Kudos, SonarCloud Quality Gate passed! |
@jaymzh Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. @marcparadise - can you also double-check?
Signed-off-by: Tensibai [email protected]
Description
Mixlib-install doesn't have a native way to add supported products out of editing the product_matrix.rb file.
This make things complex to address Chef and other distribution install from the same tool (namely for cinc for what I'm insterested about).
This proposal allow to specify an extra file using the Product DSL to add products to the matrix with their own omnitruck url.
Related Issue
#339
Types of changes
Checklist: