Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to extend the supported products of mixlib-install #340

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

Tensibai
Copy link
Contributor

@Tensibai Tensibai commented Dec 23, 2020

Signed-off-by: Tensibai [email protected]

Description

Mixlib-install doesn't have a native way to add supported products out of editing the product_matrix.rb file.
This make things complex to address Chef and other distribution install from the same tool (namely for cinc for what I'm insterested about).

This proposal allow to specify an extra file using the Product DSL to add products to the matrix with their own omnitruck url.

Related Issue

#339

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@Tensibai Tensibai requested review from a team as code owners December 23, 2020 14:44
@Tensibai Tensibai force-pushed the Extendable-Products branch from ea88532 to e977bbf Compare January 6, 2021 09:24
@Tensibai
Copy link
Contributor Author

Tensibai commented Feb 9, 2021

@chef/chef-foundation-owners Something I should do on this ?

@marcparadise
Copy link
Member

Pending conversation between @Tensibai and @ramereth to figure out best way forward.

@jaymzh
Copy link
Collaborator

jaymzh commented Aug 23, 2022

Update for followers - @ramereth is gonna chat with @Tensibai this week so we can get this sorted.

jaymzh
jaymzh previously requested changes Aug 30, 2022
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we have agreement on the approach here, but @Tensibai you need to rebase here...

@Tensibai Tensibai requested review from a team as code owners September 12, 2022 20:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Tensibai
Copy link
Contributor Author

@jaymzh Rebased

@jaymzh jaymzh dismissed their stale review September 12, 2022 20:09

code is updated

Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. @marcparadise - can you also double-check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants