Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP on issue #131 #137

Closed
wants to merge 1 commit into from
Closed

WIP on issue #131 #137

wants to merge 1 commit into from

Conversation

lamont-granquist
Copy link
Contributor

No description provided.

@tas50
Copy link
Contributor

tas50 commented Dec 17, 2018

Anything else left on this one @lamont-granquist ?

@lamont-granquist
Copy link
Contributor Author

it looks to me like this just cleans up the existing code and 'documents' the existing behavior with specs, but does not actually fix #131.

so yeah, this looks fine to merge. but won't close #131.

if we fix #131 then this would obviously go red and we'd need
 to fix it.

Signed-off-by: Lamont Granquist <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants