Skip to content

Commit

Permalink
fix: allign set_target_temperature signatures (part2) (midea-lan#177)
Browse files Browse the repository at this point in the history
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced the ability to set target temperature for Midea FB devices
with optional mode and zone parameters.

- **Improvements**
- Enhanced Midea C3 device temperature setting functionality by adding a
default value for the zone parameter.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
chemelli74 authored Jun 18, 2024
1 parent 4d8c843 commit 3466811
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
4 changes: 2 additions & 2 deletions midealocal/devices/c3/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -290,11 +290,11 @@ def set_target_temperature(
self,
target_temperature: float,
mode: int | None,
zone: int,
zone: int | None = None,
) -> None:
"""Midea C3 device set target temperature."""
message = self.make_message_set()
if self._attributes[DeviceAttributes.zone_temp_type][zone]:
if zone and self._attributes[DeviceAttributes.zone_temp_type][zone]:
message.zone_target_temp[zone] = target_temperature
else:
message.room_target_temp = target_temperature
Expand Down
8 changes: 8 additions & 0 deletions midealocal/devices/fb/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,14 @@ def set_attribute(self, attr: str, value: str | int | bool) -> None:
setattr(message, str(attr), value)
self.build_send(message)

def set_target_temperature(
self,
target_temperature: float,
mode: int | None,
zone: int | None = None,
) -> None:
"""Midea FB device set target temperature."""


class MideaAppliance(MideaFBDevice):
"""Midea FB appliance."""

0 comments on commit 3466811

Please sign in to comment.