Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update OCL to master branch #247

Merged
merged 4 commits into from
Feb 6, 2025
Merged

fix: update OCL to master branch #247

merged 4 commits into from
Feb 6, 2025

Conversation

targos
Copy link
Member

@targos targos commented Feb 6, 2025

Refs: Actelion/openchemlib#128

@lpatiny Your test case still fails after the changes.

But it seems that the test is wrong because ocl-utils tests now pass (only failures are timeouts)

This comment was marked as off-topic.

@targos
Copy link
Member Author

targos commented Feb 6, 2025

⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  __tests__/copy_molecule_by_atoms.test.js > copyMoleculeByAtoms and keep aromaticity
AssertionError: expected 1 to be 2 // Object.is equality

- Expected
+ Received

- 2
+ 1

 ❯ __tests__/copy_molecule_by_atoms.test.js:22:36
     20|   expect(fragment.getAllBonds()).toBe(2);
     21| 
     22|   expect(fragment.getBondOrder(0)).toBe(2);
       |                                    ^
     23|   expect(fragment.isDelocalizedBond(0)).toBe(true);
     24|   expect(fragment.getBondOrder(1)).toBe(1);

@targos targos merged commit 29e9f08 into main Feb 6, 2025
5 of 6 checks passed
@targos targos deleted the fix-ocl branch February 6, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants