[receiver/tcpcheck] Fit Scraper open-telemetry#34458

chengchuanpeng · Jan 26, 2025 · aa57e4d · aa57e4d
1 parent 41b7b69
commit aa57e4d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/receiver/tcpcheckreceiver/scraper.go b/receiver/tcpcheckreceiver/scraper.go
@@ -83,6 +83,7 @@ func (s *scraper) scrape(_ context.Context) (pmetric.Metrics, error) {
 	var mux sync.Mutex
 
 	for _, tcpConfig := range s.cfg.Targets {
+		// endpoint and dialer
 		go s.scrapeEndpoint(tcpConfig, &wg, &mux)
 	}
 

diff --git a/receiver/tcpcheckreceiver/testdata/expected_metrics/metrics_golden.yaml b/receiver/tcpcheckreceiver/testdata/expected_metrics/metrics_golden.yaml
@@ -7,25 +7,25 @@ resourceMetrics:
               dataPoints:
                 - asInt: "36"
                   attributes:
-                    - key: tcp.endpoint
+                    - key: tcpcheck.endpoint
                       value:
                         stringValue: 127.0.0.1:8080
                   startTimeUnixNano: "1000000"
                   timeUnixNano: "2000000"
             name: tcpcheck.duration
-            unit: ns
+            unit: ms
           - description: 1 if the TCP client successfully connected, otherwise 0.
             name: tcpcheck.status
             gauge:
               dataPoints:
                 - asInt: "1"
                   attributes:
-                    - key: tcp.endpoint
+                    - key: tcpcheck.endpoint
                       value:
                         stringValue: 127.0.0.1:8080
                   startTimeUnixNano: "1000000"
                   timeUnixNano: "2000000"
             unit: "1"
         scope:
-          name: otelcol/tcpcheckreceiver
+          name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/tcpcheckreceiver
           version: latest