merge

cherrypush · Sep 28, 2024 · a2369e6 · a2369e6
2 parents d850614 + 75d75e1
commit a2369e6
Show file tree

Hide file tree

Showing 8 changed files with 406 additions and 131 deletions.
diff --git a/.release-please-manifest.json b/.release-please-manifest.json
@@ -1,4 +1,4 @@
 {
-  ".": "2.1.1",
+  ".": "2.1.4",
   "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/manifest.json"
 }
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,146 +1,172 @@
 # Changelog
 
-## [2.1.1](https://github.com/cherrypush/cherry-cli/compare/v2.1.0...v2.1.1) (2024-09-10)
+## [2.1.4](https://github.com/cherrypush/cherry-cli/compare/v2.1.3...v2.1.4) (2024-09-27)
+
+### Bug Fixes
+
+- codeowners exact match patterns starting with slash [#109](https://github.com/cherrypush/cherry-cli/issues/109)
+  ([b751123](https://github.com/cherrypush/cherry-cli/commit/b751123716b941b97ae19a2934dfda2d71eaca5d))
 
+## [2.1.3](https://github.com/cherrypush/cherry-cli/compare/v2.1.2...v2.1.3) (2024-09-27)
 
 ### Bug Fixes
 
-* error on cherry push & migrate to typescript ([c694029](https://github.com/cherrypush/cherry-cli/commit/c6940294e278c5ebea8ab45f473bc628806764fd))
+- codeowners was consuming too much memory ([#107](https://github.com/cherrypush/cherry-cli/issues/107))
+  ([c7a3811](https://github.com/cherrypush/cherry-cli/commit/c7a3811af67492f37b2a98c59c35c280c0cd9da1))
 
-## [2.1.0](https://github.com/cherrypush/cherry-cli/compare/v2.0.1...v2.1.0) (2024-09-10)
+## [2.1.2](https://github.com/cherrypush/cherry-cli/compare/v2.1.1...v2.1.2) (2024-09-26)
+
+### Bug Fixes
+
+- codeowners didn't work for paths starting with / ([#105](https://github.com/cherrypush/cherry-cli/issues/105))
+  ([a05682f](https://github.com/cherrypush/cherry-cli/commit/a05682ff0543fe60f43d29deaf5c543d1fe715db))
 
+## [2.1.1](https://github.com/cherrypush/cherry-cli/compare/v2.1.0...v2.1.1) (2024-09-10)
+
+### Bug Fixes
+
+- error on cherry push & migrate to typescript
+  ([c694029](https://github.com/cherrypush/cherry-cli/commit/c6940294e278c5ebea8ab45f473bc628806764fd))
+
+## [2.1.0](https://github.com/cherrypush/cherry-cli/compare/v2.0.1...v2.1.0) (2024-09-10)
 
 ### Features
 
-* migrate to typescript ([#95](https://github.com/cherrypush/cherry-cli/issues/95)) ([3ce73eb](https://github.com/cherrypush/cherry-cli/commit/3ce73ebca965cd393ceffd66aedd74a937c7fa4a))
+- migrate to typescript ([#95](https://github.com/cherrypush/cherry-cli/issues/95))
+  ([3ce73eb](https://github.com/cherrypush/cherry-cli/commit/3ce73ebca965cd393ceffd66aedd74a937c7fa4a))
 
 ## [2.0.1](https://github.com/cherrypush/cherry-cli/compare/v2.0.0...v2.0.1) (2024-09-09)
 
-
 ### Bug Fixes
 
-* TS import issue ([#92](https://github.com/cherrypush/cherry-cli/issues/92)) ([bef3eb1](https://github.com/cherrypush/cherry-cli/commit/bef3eb15a588ea8078764124eed7dd91e823ef01))
+- TS import issue ([#92](https://github.com/cherrypush/cherry-cli/issues/92))
+  ([bef3eb1](https://github.com/cherrypush/cherry-cli/commit/bef3eb15a588ea8078764124eed7dd91e823ef01))
 
 ## [2.0.0](https://github.com/cherrypush/cherry-cli/compare/v1.13.0...v2.0.0) (2024-09-09)
 
-
 ### ⚠ BREAKING CHANGES
 
-* start migrating to typescript ([#52](https://github.com/cherrypush/cherry-cli/issues/52))
+- start migrating to typescript ([#52](https://github.com/cherrypush/cherry-cli/issues/52))
 
 ### Features
 
-* start migrating to typescript ([#52](https://github.com/cherrypush/cherry-cli/issues/52)) ([c6833a4](https://github.com/cherrypush/cherry-cli/commit/c6833a4f7572dede3cde6809e99855eb77be01a8))
-
+- start migrating to typescript ([#52](https://github.com/cherrypush/cherry-cli/issues/52))
+  ([c6833a4](https://github.com/cherrypush/cherry-cli/commit/c6833a4f7572dede3cde6809e99855eb77be01a8))
 
 ### Bug Fixes
 
-* bump micromatch and lint-staged ([#86](https://github.com/cherrypush/cherry-cli/issues/86)) ([8839f72](https://github.com/cherrypush/cherry-cli/commit/8839f72c5e14d2aa06c8bbc648d8d032e3bc706e))
-* improve docs with details about the configuration file ([becc5ff](https://github.com/cherrypush/cherry-cli/commit/becc5ff3c6a1940a0f0aaec5ff1aad57579df765))
+- bump micromatch and lint-staged ([#86](https://github.com/cherrypush/cherry-cli/issues/86))
+  ([8839f72](https://github.com/cherrypush/cherry-cli/commit/8839f72c5e14d2aa06c8bbc648d8d032e3bc706e))
+- improve docs with details about the configuration file
+  ([becc5ff](https://github.com/cherrypush/cherry-cli/commit/becc5ff3c6a1940a0f0aaec5ff1aad57579df765))
 
 ## [1.13.0](https://github.com/cherrypush/cherry-cli/compare/v1.12.2...v1.13.0) (2024-09-08)
 
-
 ### Features
 
-* allow custom permalinks ([#84](https://github.com/cherrypush/cherry-cli/issues/84)) ([63485a7](https://github.com/cherrypush/cherry-cli/commit/63485a770d67ec65b7ef02da64ad22dff9ffea63))
-
+- allow custom permalinks ([#84](https://github.com/cherrypush/cherry-cli/issues/84))
+  ([63485a7](https://github.com/cherrypush/cherry-cli/commit/63485a770d67ec65b7ef02da64ad22dff9ffea63))
 
 ### Bug Fixes
 
-* **dev:** bump @commitlint/config-conventional from 18.4.3 to 19.4.1 ([#81](https://github.com/cherrypush/cherry-cli/issues/81)) ([e7cea20](https://github.com/cherrypush/cherry-cli/commit/e7cea2093dfcae68ece6ae4aafd2204a6bf5db61))
-* use relative path for eslint ([#83](https://github.com/cherrypush/cherry-cli/issues/83)) ([bc1cdac](https://github.com/cherrypush/cherry-cli/commit/bc1cdac963a82f63f88356ec72aa5cf3f1f856ac))
+- **dev:** bump @commitlint/config-conventional from 18.4.3 to 19.4.1
+  ([#81](https://github.com/cherrypush/cherry-cli/issues/81))
+  ([e7cea20](https://github.com/cherrypush/cherry-cli/commit/e7cea2093dfcae68ece6ae4aafd2204a6bf5db61))
+- use relative path for eslint ([#83](https://github.com/cherrypush/cherry-cli/issues/83))
+  ([bc1cdac](https://github.com/cherrypush/cherry-cli/commit/bc1cdac963a82f63f88356ec72aa5cf3f1f856ac))
 
 ## [1.12.2](https://github.com/cherrypush/cherry-cli/compare/v1.12.1...v1.12.2) (2024-09-07)
 
-
 ### Bug Fixes
 
-* update readme and fix owners option from cherry run ([92c4e9c](https://github.com/cherrypush/cherry-cli/commit/92c4e9caac91c842b1308eb9b5ccc6470002a7fe))
+- update readme and fix owners option from cherry run
+  ([92c4e9c](https://github.com/cherrypush/cherry-cli/commit/92c4e9caac91c842b1308eb9b5ccc6470002a7fe))
 
 ## [1.12.1](https://github.com/cherrypush/cherry-cli/compare/v1.12.0...v1.12.1) (2024-09-07)
 
-
 ### Bug Fixes
 
-* update axios from 1.6.2 to 1.7.7 ([c274586](https://github.com/cherrypush/cherry-cli/commit/c27458696d1d33331d854da23161a7c65303e8f7))
-* update braces to 3.0.3 ([f61567a](https://github.com/cherrypush/cherry-cli/commit/f61567ab625cd84d4b3d877cae63dfa727f0e85c))
+- update axios from 1.6.2 to 1.7.7
+  ([c274586](https://github.com/cherrypush/cherry-cli/commit/c27458696d1d33331d854da23161a7c65303e8f7))
+- update braces to 3.0.3
+  ([f61567a](https://github.com/cherrypush/cherry-cli/commit/f61567ab625cd84d4b3d877cae63dfa727f0e85c))
 
 ## [1.12.0](https://github.com/cherrypush/cherry-cli/compare/v1.11.0...v1.12.0) (2024-09-07)
 
-
 ### Features
 
-* handle https remotes when trying to guess project name ([#73](https://github.com/cherrypush/cherry-cli/issues/73)) ([a254986](https://github.com/cherrypush/cherry-cli/commit/a2549866f083d23828dd158cd4f9ac37bcf04858))
+- handle https remotes when trying to guess project name ([#73](https://github.com/cherrypush/cherry-cli/issues/73))
+  ([a254986](https://github.com/cherrypush/cherry-cli/commit/a2549866f083d23828dd158cd4f9ac37bcf04858))
 
 ## [1.11.0](https://github.com/cherrypush/cherry-cli/compare/v1.10.0...v1.11.0) (2024-09-06)
 
-
 ### Features
 
-* filter out metrics for cherry diff (part 2) ([36024aa](https://github.com/cherrypush/cherry-cli/commit/36024aa2bcbde6ee1cd52a944e674e48aef8b3b7))
+- filter out metrics for cherry diff (part 2)
+  ([36024aa](https://github.com/cherrypush/cherry-cli/commit/36024aa2bcbde6ee1cd52a944e674e48aef8b3b7))
 
 ## [1.10.0](https://github.com/cherrypush/cherry-cli/compare/v1.9.2...v1.10.0) (2024-09-05)
 
-
 ### Features
 
-* filter out metrics for cherry diff ([#68](https://github.com/cherrypush/cherry-cli/issues/68)) ([12189df](https://github.com/cherrypush/cherry-cli/commit/12189dfd715ac1260d30c6733884cc66659ebf2a))
+- filter out metrics for cherry diff ([#68](https://github.com/cherrypush/cherry-cli/issues/68))
+  ([12189df](https://github.com/cherrypush/cherry-cli/commit/12189dfd715ac1260d30c6733884cc66659ebf2a))
 
 ## [1.9.2](https://github.com/cherrypush/cherry-cli/compare/v1.9.1...v1.9.2) (2024-09-05)
 
-
 ### Bug Fixes
 
-* add registry url to setup node step ([2157ef0](https://github.com/cherrypush/cherry-cli/commit/2157ef0d9b85ac6b4661132899616fc356efd379))
-* automate package publishing ([#64](https://github.com/cherrypush/cherry-cli/issues/64)) ([6e4a420](https://github.com/cherrypush/cherry-cli/commit/6e4a4203277f6532cff6961357ed6ed698a57c2e))
+- add registry url to setup node step
+  ([2157ef0](https://github.com/cherrypush/cherry-cli/commit/2157ef0d9b85ac6b4661132899616fc356efd379))
+- automate package publishing ([#64](https://github.com/cherrypush/cherry-cli/issues/64))
+  ([6e4a420](https://github.com/cherrypush/cherry-cli/commit/6e4a4203277f6532cff6961357ed6ed698a57c2e))
 
 ## [1.9.1](https://github.com/cherrypush/cherry-cli/compare/v1.9.0...v1.9.1) (2024-09-05)
 
-
 ### Bug Fixes
 
-* automation to release package ([#62](https://github.com/cherrypush/cherry-cli/issues/62)) ([a6ba9d7](https://github.com/cherrypush/cherry-cli/commit/a6ba9d731eb59f37eab284232b12f3c7bfddf1f6))
+- automation to release package ([#62](https://github.com/cherrypush/cherry-cli/issues/62))
+  ([a6ba9d7](https://github.com/cherrypush/cherry-cli/commit/a6ba9d731eb59f37eab284232b12f3c7bfddf1f6))
 
 ## [1.9.0](https://github.com/cherrypush/cherry-cli/compare/v1.8.0...v1.9.0) (2024-09-05)
 
-
 ### Features
 
-* update madge (used for jsCircularDependencies plugin) ([#60](https://github.com/cherrypush/cherry-cli/issues/60)) ([7bf126a](https://github.com/cherrypush/cherry-cli/commit/7bf126ab5e734f393ae466d84ab3b0161592c9a0))
+- update madge (used for jsCircularDependencies plugin) ([#60](https://github.com/cherrypush/cherry-cli/issues/60))
+  ([7bf126a](https://github.com/cherrypush/cherry-cli/commit/7bf126ab5e734f393ae466d84ab3b0161592c9a0))
 
 ## [1.8.0](https://github.com/cherrypush/cherry-cli/compare/v1.7.0...v1.8.0) (2024-08-30)
 
-
 ### Features
 
-* automatically publish npm package when release please pr is merged ([7bdfaf2](https://github.com/cherrypush/cherry-cli/commit/7bdfaf26bd5c1f1e65e28f394b29952845ad48cc))
+- automatically publish npm package when release please pr is merged
+  ([7bdfaf2](https://github.com/cherrypush/cherry-cli/commit/7bdfaf26bd5c1f1e65e28f394b29952845ad48cc))
 
 ## [1.7.0](https://github.com/cherrypush/cherry-cli/compare/v1.6.0...v1.7.0) (2024-08-30)
 
-
 ### Features
 
-* allow to provide multiple metrics to cherry run ([#56](https://github.com/cherrypush/cherry-cli/issues/56)) ([8350602](https://github.com/cherrypush/cherry-cli/commit/8350602a4ed5deef2025dfdd402c890bf6916e0f))
+- allow to provide multiple metrics to cherry run ([#56](https://github.com/cherrypush/cherry-cli/issues/56))
+  ([8350602](https://github.com/cherrypush/cherry-cli/commit/8350602a4ed5deef2025dfdd402c890bf6916e0f))
 
 ## [1.6.0](https://github.com/cherrypush/cherry-cli/compare/v1.5.0...v1.6.0) (2024-07-01)
 
-
 ### Features
 
-* **performance-alerts:** WIP ([#51](https://github.com/cherrypush/cherry-cli/issues/51)) ([6c9ae5f](https://github.com/cherrypush/cherry-cli/commit/6c9ae5f6d7c2e63513064db2796837d59673c0e2))
-
+- **performance-alerts:** WIP ([#51](https://github.com/cherrypush/cherry-cli/issues/51))
+  ([6c9ae5f](https://github.com/cherrypush/cherry-cli/commit/6c9ae5f6d7c2e63513064db2796837d59673c0e2))
 
 ### Bug Fixes
 
-* checkout merge base for cherry diff ([#37](https://github.com/cherrypush/cherry-cli/issues/37)) ([db1106b](https://github.com/cherrypush/cherry-cli/commit/db1106bcff3792946ea0e7abc75e67506cd8bee7))
+- checkout merge base for cherry diff ([#37](https://github.com/cherrypush/cherry-cli/issues/37))
+  ([db1106b](https://github.com/cherrypush/cherry-cli/commit/db1106bcff3792946ea0e7abc75e67506cd8bee7))
 
 ## [1.5.0](https://github.com/cherrypush/cherry-cli/compare/v1.4.0...v1.5.0) (2023-12-16)
 
-
 ### Features
 
-* make cherry diff agnostic from cherrypush.com  ([#31](https://github.com/cherrypush/cherry-cli/issues/31)) ([63bb651](https://github.com/cherrypush/cherry-cli/commit/63bb65126dc3b65dd822f930a13a03fcf25355d7))
+- make cherry diff agnostic from cherrypush.com ([#31](https://github.com/cherrypush/cherry-cli/issues/31))
+  ([63bb651](https://github.com/cherrypush/cherry-cli/commit/63bb65126dc3b65dd822f930a13a03fcf25355d7))
 
 ## [1.4.0](https://github.com/cherrypush/cherry-cli/compare/v1.3.0...v1.4.0) (2023-12-02)
 

diff --git a/CODEOWNERS b/CODEOWNERS
@@ -1,13 +1,20 @@
 # These owners will be the default owners for everything in
 # the repo. Unless a later match takes precedence,
-* @fwuensche
+* @root
 
 # Order is important; the last matching pattern takes the most
 # precedence. When someone opens a pull request that only
 # modifies JS files, only these and not the global
 # owner(s) will be requested for a review.
-*.js @fwuensche
+*.js @javascript
 
 # In this example, the user owns any files in the src directory
 # at the root of the repository and any of its subdirectories.
-/src/ @fwuensche
+/src/ @source
+
+# There's a plugin folder inside /src/ that we'll be using to test
+# that the pattern matching is working correctly. See codeowners.test.ts
+plugins/ @plugins
+
+# This should override the plugins/ rule above and assign the user
+/src/plugins/eslint.js @eslint-plugin