feat: add support to custom repository info #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwuensche
changed the title
QuentinLemCode
approved these changes
Sep 24, 2024
bin/commands/push.ts
Outdated
Comment on lines
73
to
74
| console.error(error) | ||
| process.exit(1) |
There was a problem hiding this comment.
You could put this inside the catch clause, allowing to remove the error variable
There was a problem hiding this comment.
Good point. The problem is that when I call process.exit(1), the process is terminated, so the finally block will never be executed. However, I've just figured that we can also just change the process code with:
process.exitCode = 1
Comment on lines
62
to
73
| if (format === 'json') { | ||
| const metrics = buildMetricsPayload(occurrences) | ||
| content = JSON.stringify(metrics, null, 2) | ||
| } else if (format === 'sarif') { | ||
| const branch = await git.branchName() | ||
| const sha = await git.sha() | ||
| const sarif = buildSarifPayload(configuration.project_name, branch, sha, occurrences) | ||
| const sarif = buildSarifPayload(configuration.repository, branch, sha, occurrences) | ||
| content = JSON.stringify(sarif, null, 2) | ||
| } else if (format === 'sonar') { | ||
| const sonar = buildSonarGenericImportPayload(occurrences) | ||
| content = JSON.stringify(sonar, null, 2) | ||
| } |
There was a problem hiding this comment.
Another way to do this is by doing a mapping, like this :
const buildPayloadMapping: Record<keyof ALLOWED_FORMATS, () => object> = {
json: () => buildMetricsPayload(occurences),
sonar: () => buildSonarGenericImportPayload(occurences),
sarif: async () => {
const branch = await git.branchName()
const sha = await git.sha()
return buildSarifPayload(...)
}
}
const content = JSON.stringify(await buildPayloadMapping[format], null, 2)There was a problem hiding this comment.
I'm having a hard time with this one because some of the mappings are async while others are not. I'll make this change in a follow-up PR.
| export const upload = async (apiKey: string, projectName: string, date: Date, occurrences: Occurrence[]) => { | ||
| if (!projectName) panic('specify a project_name in your cherry.js configuration file before pushing metrics') | ||
|
|
||
| const uuid = await v4() | ||
| const uuid = v4() |
There was a problem hiding this comment.
You could also use randomUUID which is an ECMAscript feature : https://developer.mozilla.org/en-US/docs/Web/API/Crypto/randomUUID
It would allow you to remove the uuid dependency
There was a problem hiding this comment.
Thanks! Will also do it in another PR.
fwuensche
added a commit
that referenced
this pull request
Oct 4, 2024
* wip * wip * remove * Initial commit * fix test * fix types * rollback * chore * chore * setup auto formatting * silence fixture setup script * add commit url to contributions payload * test contributions payload * use relative imports * fix deprecated method * stop suggesting dist folder for imports * fix test * prevent push if there are uncommitted changes * fix lint * increase timeout in ci * refactor * refactor * handle error * rollback * as const * type * fix test * remove async * remove finally * remove project name * add project name
fwuensche
added a commit
that referenced
this pull request
Oct 4, 2024
* wip * wip * remove * Initial commit * fix test * fix types * rollback * chore * chore * setup auto formatting * silence fixture setup script * add commit url to contributions payload * test contributions payload * use relative imports * fix deprecated method * stop suggesting dist folder for imports * fix test * prevent push if there are uncommitted changes * fix lint * increase timeout in ci * refactor * refactor * handle error * rollback * as const * type * fix test * remove async * remove finally * remove project name * add project name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #98