Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codeowners didn't work for paths starting with / #105

Merged
merged 2 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
# precedence. When someone opens a pull request that only
# modifies JS files, only these and not the global
# owner(s) will be requested for a review.
*.js @fwuensche
*.js @rchoquet

# In this example, the user owns any files in the src directory
# at the root of the repository and any of its subdirectories.
/src/ @fwuensche
/src/ @fwuensche @rchoquet
188 changes: 183 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"cherry": "tsx ./bin/cherry.ts",
"prepare": "husky install && npm run build",
"bump": "npm version patch && npm publish",
"test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watchAll",
"test:watch": "vitest watch",
"lint": "eslint . --ext .js,.ts",
"test": "sh test/fixtures/setup.sh && vitest run",
"test:setup": "sh test/fixtures/setup.sh",
Expand All @@ -39,6 +39,7 @@
"homepage": "https://github.com/fwuensche/cherry-cli#readme",
"dependencies": {
"axios": "^1.2.3",
"codeowners": "^5.1.1",
"commander": "^10.0.0",
"dotenv": "^16.4.5",
"esbuild": "^0.20.0",
Expand All @@ -54,6 +55,7 @@
"uuid": "^9.0.1"
},
"devDependencies": {
"@types/glob": "^8.1.0",
"@types/lodash": "^4.17.7",
"@types/spinnies": "^0.5.3",
"@types/uuid": "^10.0.0",
Expand Down
78 changes: 0 additions & 78 deletions src/codeowners.js

This file was deleted.

Loading