Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable forked and unpin pytest #681

Closed
wants to merge 1 commit into from
Closed

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Apr 16, 2024

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)

Resolves #

❓ What is the current behavior? (You can also link to an open issue here)

❓ What is the new behavior (if this is a feature change)?

πŸ“‹ Other information:

πŸ“‹ Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

@jaraco
Copy link
Member Author

jaraco commented Apr 16, 2024

@webknjaz Per your request, I'll not merge this and I'll leave it to you to follow-up later.

@webknjaz
Copy link
Member

@jaraco thank you!

@webknjaz
Copy link
Member

FYI the tests fail because the pip wrapper in tox auto-injects the constraints into the pip install commands when the corresponding lock files exist. And since those pins aren't updated, this creates a conflict in dependency resolution.

@jaraco jaraco force-pushed the bugfix/511-unpin-pytest branch from 801f376 to 3cd212f Compare April 16, 2024 01:22
@webknjaz webknjaz force-pushed the bugfix/511-unpin-pytest branch from 3cd212f to 0c41b7b Compare April 26, 2024 00:59
webknjaz pushed a commit to webknjaz/cheroot that referenced this pull request Apr 27, 2024
This plugin is incompatible with Pytest 7+, it's difficult to fix
upstream and there is no timeline for addressing that.

The patch also bumps the top version boundary of Pytest to 7.2 due
to the pinned `pytest-cov` raising warnings.

Fixes #cherrypy#502
Resolves cherrypy#511
Closes cherrypy#680
Resolves cherrypy#681
@webknjaz webknjaz mentioned this pull request Apr 27, 2024
6 tasks
@webknjaz webknjaz closed this in a01ada6 Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants