-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lowering recall threshold #912
base: develop
Are you sure you want to change the base?
lowering recall threshold #912
Conversation
Thx for the contribution! For me is ok but i would prefer to have a central module to store all classes like this one. What do you think @pieroit ? |
@scicco sorry for the delay, left some suggestions. Let me know if you can do it or I'll try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
No problem, I'll work on that |
97cc8c3
to
ad5f3b5
Compare
Hello @pieroit, I've implemented the changes. If something should be changed or fixed, let me know, and I'll do it. Thank you |
ad5f3b5
to
2006338
Compare
Description
This is my first attempt to try to contribute a bit to this awesome project😹
This commit will lower the recall threshold. It also separates the config introducing the
RecallSettings
class as suggested in TODOI've set the following constant values:
please let me know if those values are appropriate.
Related to issue (#909)
Type of change
Checklist: