Refactored updateCastle()

chesslablab · Jan 28, 2025 · 22830cc · 22830cc
1 parent ec2255f
commit 22830cc
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/Variant/AbstractPiece.php b/src/Variant/AbstractPiece.php
@@ -439,21 +439,20 @@ public function capture(): void
      */
     public function updateCastle(): AbstractPiece
     {
+        $search = '';
         if ($this->id === Piece::K) {
             $search = $this->board->turn === Color::W ? 'KQ' : 'kq';
-            $this->board->castlingAbility = str_replace($search, '', $this->board->castlingAbility)
-                ?: CastlingRule::NEITHER;
         } elseif ($this->id === Piece::R) {
             if ($this->type === RType::CASTLE_SHORT) {
                 $search = $this->board->turn === Color::W ? 'K' : 'k';
-                $this->board->castlingAbility = str_replace($search, '', $this->board->castlingAbility)
-                    ?: CastlingRule::NEITHER;
             } elseif ($this->type === RType::CASTLE_LONG) {
                 $search = $this->board->turn === Color::W ? 'Q' : 'q';
-                $this->board->castlingAbility = str_replace($search, '', $this->board->castlingAbility)
-                    ?: CastlingRule::NEITHER;
             }
         }
+        if ($search) {
+            $this->board->castlingAbility = str_replace($search, '', $this->board->castlingAbility) 
+                ?: CastlingRule::NEITHER;
+        }
 
         return $this;
     }