Support logger without variable argument list #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
school510587
changed the title
jserv
reviewed
Aug 9, 2017
|
Hi @jserv,
I just follow the style of naming of chewing_new2.
Actually I don't know how to select a meaningful name for chewing_set_logger2, because it may be too long.
Do you think a name like chewing_set_logger_without_varglist is proper?
|
|
Cc. @czchen The functionality of |
jserv
reviewed
Aug 11, 2017
| @@ -545,7 +545,7 @@ CHEWING_API int chewing_get_phoneSeqLen(const ChewingContext *ctx); | |||
| CHEWING_API void chewing_set_logger(ChewingContext *ctx, | |||
| void (*logger) (void *data, int level, const char *fmt, ...), void *data); | |||
|
|
|||
| CHEWING_API void chewing_set_logger2(ChewingContext *ctx, | |||
| CHEWING_API void chewing_set_logger_without_varglist(ChewingContext *ctx, | |||
There was a problem hiding this comment.
The suffix without_varglist is too long. I would expected to revise the use of API instead.
|
How about using Swig to resolve the convention? |
|
Can you rebase for reviewing? |
Data4NoVarArgListLogger keeps the real logger and data obtained from the caller. Logger4NoVarArgList collects message properly and forwards it to the real logger.
school510587
force-pushed
the
no_var_arg_list_logger
branch
from
4ba342c
to
016873b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libchewing only accepts logger callback with variable argument list so far. However, it seems difficult to implement such callback using other language (eg. Python). This prevents direct access of log messages. Here, the PR implements a new built-in logger and a new API to remove the restriction.