Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add spinner without bar #368

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

preterer
Copy link

@preterer preterer commented Oct 3, 2017

Hey,
I've noticed you can't actually add the spinner when bar is not included, so I provided a hotfix.

Add spinner after the $after element when bar is not included
@jrobichaud
Copy link

jrobichaud commented Aug 22, 2018

I confirm your fix works.

Until this is merged, you can load a dummy loading bar instead:

    cfpLoadingBarProvider.includeBar = true;
    cfpLoadingBarProvider.loadingBarTemplate = "<div></div>";

The spinner starts to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants