Skip to content

Commit

Permalink
Omit golangci-lint as it does not seem to work well with aws-sdk-go-v2
Browse files Browse the repository at this point in the history
  • Loading branch information
bwhaley committed May 10, 2024
1 parent 3b3895b commit 49f2f13
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 75 deletions.
54 changes: 16 additions & 38 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ jobs:
pip install -r functions/replace-route/tests/test_requirements.txt
python -m pytest
golang_lint:
terraform_tests:
permissions:
id-token: write
contents: read
runs-on: ubuntu-latest
defaults:
Expand All @@ -34,46 +35,23 @@ jobs:
uses: actions/setup-go@v5
with:
go-version-file: test/go.mod
cache-dependency-path: test/go.sum

- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.53
working-directory: ./test

# use config in .golangci.yaml to configure the action further
# terraform_tests:
# permissions:
# id-token: write
# contents: read
# runs-on: ubuntu-latest
# defaults:
# run:
# working-directory: ./test
# steps:
# - uses: actions/checkout@v4

# - name: Install Go
# uses: actions/setup-go@v5
# with:
# go-version-file: test/go.mod
# cache-dependency-path: test/go.sum
- name: Go Tidy
run: go mod tidy && git diff --exit-code

# - name: Go Tidy
# run: go mod tidy && git diff --exit-code
- name: Go Mod
run: go mod download

# - name: Go Mod
# run: go mod download
- name: Go mod verify
run: go mod verify

# - name: Go mod verify
# run: go mod verify
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ secrets.TERRATEST_ROLE_TO_ASSUME }}
aws-region: ${{ secrets.AWS_REGION }}

# - name: Configure AWS Credentials
# uses: aws-actions/configure-aws-credentials@v4
# with:
# role-to-assume: ${{ secrets.TERRATEST_ROLE_TO_ASSUME }}
# aws-region: ${{ secrets.AWS_REGION }}
- name: Run tests
run: go test -v -timeout 60m

# - name: Run tests
# run: go test -v -timeout 60m

37 changes: 0 additions & 37 deletions .golangci.yaml

This file was deleted.

0 comments on commit 49f2f13

Please sign in to comment.