Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Remove Empty state #7

Closed
chimon2000 opened this issue Apr 27, 2020 · 0 comments · Fixed by #11
Closed

[Feature]: Remove Empty state #7

chimon2000 opened this issue Apr 27, 2020 · 0 comments · Fixed by #11
Assignees
@chimon2000
Labels
enhancement New feature or request

Comments

@chimon2000
Copy link
Owner

Is your feature request related to a problem? Please describe.
To make this library more in line with pure RemoteData implementations, we should remove the Empty state, which is not reflective of the state of an asynchronous operation but rather the state of the data itself.

Describe the solution you'd like
Deprecate Empty state, and update examples. Will be removed in 1.0 version.

Describe alternatives you've considered
An alternative would be to leave this state in, however that would mean that the data model is polluted with UI concerns.

Additional context

Issues with related scope creep concerns:

devexperts/remote-data-ts#22 (comment)
krisajenkins/remotedata#9
@chimon2000 chimon2000 added the enhancement New feature or request label Apr 27, 2020
@chimon2000 chimon2000 self-assigned this Apr 27, 2020
@chimon2000 chimon2000 mentioned this issue May 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chimon2000 chimon2000

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove empty state chimon2000/remote_state
1 participant
@chimon2000