Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty state #11

Merged
merged 8 commits into from
May 6, 2020
Merged

Remove empty state #11

merged 8 commits into from
May 6, 2020

Conversation

chimon2000
Copy link
Owner

This pr includes several 1.0 changes.

  • Removing empty states
  • Adding state predicates
  • Enhancing errors with dynamic errors and stack traces.

Work left (if wip):

n/a

Related Issue

Resolves #7, #10, #9

How Has This Been Tested?

Automated tests

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

This was linked to issues May 4, 2020
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #11 into master will increase coverage by 3.18%.
The diff coverage is 84.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   76.56%   79.75%   +3.18%     
==========================================
  Files           1        2       +1     
  Lines         192      242      +50     
==========================================
+ Hits          147      193      +46     
- Misses         45       49       +4     
Impacted Files Coverage Δ
packages/remote_state/lib/remote_state.dart 0.00% <0.00%> (ø)
...ackages/remote_state/lib/remote_state.freezed.dart 82.47% <91.00%> (+5.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39839f3...d7d3331. Read the comment docs.

chimon2000 added 3 commits May 5, 2020 19:56
BREAKING CHANGE:  empty is no longer supported because it is not considered a valid remote state.
@chimon2000 chimon2000 merged commit cc70c40 into master May 6, 2020
@chimon2000 chimon2000 deleted the feat/remote_empty branch May 6, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Error enhancements [Feature]: Add state predicates [Feature]: Remove Empty state
1 participant