#240 Made Wire receiveFrom stopMaster() optional #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BEFORE MERGING THIS NEEDS TESTING BY SOMEONE WITH A SUITABLE SETUPI don't have a setup that needs this functionality at the moment and can't test the knock-on effect of it. If someone that has a setup that would use this parameter could test it before merging that would be a huge benefit. |
|
Potential fix for issue #240 |
|
What is required to test that this change works? Generating a request to an I2C slave in multiple parts without a stop in between each requestFrom() except the last? |
|
Yeah, with some device that expects to work that way. |
|
If such a device can be identified, I may be able to test. |
|
I have a feeling things like EEPROMS may work this way. First set an address, then read from that address without restarting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional boolean parameter to
Wire.requestFrom()which then is used to wrap thedi2c.stopMaster()call to make executing it optional.