fix(select-ui): set nowrap on window to prevent visual overflow #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signcolumn is part of the window width, which makes the padding too long if it's visible.
|
Works for me. Makes sense why the issue was happening and how you solved it. If someone really has a title that long, I'm willing to have this issue get surfaced later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating the padding for the selection UI, the window width includes the signcolumn, if it's open. In combination with
wrap, this leads to seemingly blank lines between items (the red is a highlight for trailing whitespace):I couldn't find a way to get the signcolumn width, but disabling line wrapping seems like an OK workaround.
This may change how very long titles are displayed, as these will now be visually truncated. If that's an issue, feel free to close this. I can also just fix this in my local configuration with filetype options for the org-roam-select.