-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mail-listener2 with changes from another forks #72
Conversation
Set mime dependency version to ^1.0.0 because mime 2.0.0 package breaks the API
Update readme to describe what changes are included and be in line with the name of the new library and new features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your work! I hope it would be merged soon
}, function(err){ | ||
if( err ) { | ||
}, function (err) { | ||
console.log('all process'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log is redundant
"name": "mail-listener2", | ||
"version": "0.3.1", | ||
"description": "Mail listener library for node.js. Get notification when new email arrived.", | ||
"name": "mail-listener2-updated", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name is wrong
"url": "http://chiragjain.tumblr.com" | ||
"name": "Daniel Pérez", | ||
"email": "dapanas@gmail.com", | ||
"url": "http://blogcito.info" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url, homepage, author are wrong
* Add a restart function to reconnect to imap server | ||
* Enhanced logging for the new features | ||
* Pass email object to attachment event | ||
* Update mime dependency version to ^1.0.0 because mime 2.0.0 package break the API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description should be fixed
|
||
|
||
JavaScript Code: | ||
|
||
|
||
```javascript | ||
|
||
var MailListener = require("mail-listener2"); | ||
var MailListener = require("mail-listener2-updated"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package name is wrong
this.imap.removeAllListeners('mail'); | ||
this.imap.removeAllListeners('update'); | ||
|
||
console.log('calling imap connect'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two consoles probably can be removed
Closed and replaced by #74. |
This pull request includes changes and improvements from another forks.
The changes are:
Every commit was made by me giving the right credit to the original authors.