Implement Mailer#canSend #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag04
reviewed
Jan 17, 2017
| ```js | ||
| var Mailer = require('NativeModules').RNMail; | ||
|
|
||
| Mailer.canSend((error, canSend) => { |
There was a problem hiding this comment.
seems like error in the callback is always null. Seems like outcome canSend is always true or false. maybe keep the apis Mailer.canSend(canSend => {});?
There was a problem hiding this comment.
You are right, but I wanted to stick to the error-first callback convention. I think this is more valuable than saving an argument.
What do you think?
There was a problem hiding this comment.
i would prefer to follow rn convention over node. refer: https://github.com/facebook/react-native/blob/4a893ee071f76377a678fe9774190397f636598a/Libraries/CameraRoll/RCTImagePickerManager.m#L49
|
Hey, I need this ability too, is this something that is going to be? |
|
@martijndeh can you update? |
|
@chirag04 is it possible to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need a way to check if the user is able to send a mail. Please let me know if you have any feedback.