-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple attachments [OUTDATED] #92
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR. Looks good overall. Will merge soon. |
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a syntax error. One too many closing brackets.
README.md
Outdated
@@ -125,11 +125,11 @@ export default class App extends Component { | |||
bccRecipients: ['[email protected]'], | |||
body: '<b>A Bold Body</b>', | |||
isHTML: true, | |||
attachment: { | |||
attachments: {[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to switch the order of the curly and square brackets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks will sort now..
when will this be merged? Need the ability to add multiple attachments |
Good question. @chirag04? For now you can use my fork https://github.com/adamski/react-native-mail |
How has this not still been added.. really disappointing. |
Woah! Can't believe this is still not possible ... Please Merge! |
What’s the latest with getting support for this merged into a release? Or is there a better fork we all should switch to? |
Can folks try the latest version and see if this is still an issue? |
Rebased #11 (the first PR for multiple attachments). Tested and working on iOS, and with Android changes from @kneza23
Breaking changes
attachment:{}
is nowattachments:[]
, e.g.: