Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple attachments [OUTDATED] #92

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

adamski
Copy link
Contributor

@adamski adamski commented Dec 11, 2017

Rebased #11 (the first PR for multiple attachments). Tested and working on iOS, and with Android changes from @kneza23

Breaking changes

attachment:{} is now attachments:[], e.g.:

Mailer.mail({
      subject: 'My email with attachments',
      recipients: [],
      body: 'Check this out',
      isHTML: true,
      attachments: [{
        path: this.imageFilePath,  // The absolute path of the file from which to read data.
        type: 'png',   // Mime Type: jpg, png, doc, ppt, html, pdf
      },{
        path: this.audioFilePath,
        type: 'wav',   
      }]
    }, (error, event) => {
      Alert.alert(
        error,
        event,
        [
          {text: 'OK', onPress: () => console.log('OK: Email Error Response')},
        ],
        { cancelable: true }
      )
    });

@chirag04
Copy link
Owner

Thanks for the PR. Looks good overall. Will merge soon.

}
}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a syntax error. One too many closing brackets.

README.md Outdated
@@ -125,11 +125,11 @@ export default class App extends Component {
bccRecipients: ['[email protected]'],
body: '<b>A Bold Body</b>',
isHTML: true,
attachment: {
attachments: {[

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to switch the order of the curly and square brackets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks will sort now..

@adunn511
Copy link

adunn511 commented Mar 9, 2018

when will this be merged? Need the ability to add multiple attachments

@adamski
Copy link
Contributor Author

adamski commented Mar 9, 2018

Good question. @chirag04?

For now you can use my fork https://github.com/adamski/react-native-mail

@adamski adamski changed the title Multiple attachments Multiple attachments [OUTDATED] Jun 8, 2018
@elmbrent
Copy link

elmbrent commented Jan 14, 2019

How has this not still been added.. really disappointing.

@brandtnewlabs
Copy link

Woah! Can't believe this is still not possible ... Please Merge!

@PvanHengel
Copy link

What’s the latest with getting support for this merged into a release? Or is there a better fork we all should switch to?

@chirag04
Copy link
Owner

chirag04 commented Sep 3, 2020

Can folks try the latest version and see if this is still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants