Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React.PropTypes, React.createClass replaced for RN 0.49+ #33

Closed
wants to merge 1 commit into from
Closed

React.PropTypes, React.createClass replaced for RN 0.49+ #33

wants to merge 1 commit into from

Conversation

fungilation
Copy link

@fungilation fungilation commented Oct 11, 2017

Fixes #30, #31

Redbox errors otherwise.

@fungilation fungilation changed the title fixed #31: React.PropTypes replaced with new 'prop-types' for RN 0.49+ fixed #31: React.PropTypes, React.createClass replaced for RN 0.49+ Oct 11, 2017
@fungilation fungilation changed the title fixed #31: React.PropTypes, React.createClass replaced for RN 0.49+ React.PropTypes, React.createClass replaced for RN 0.49+ Oct 11, 2017
@adlenafane
Copy link

@chirag04 Hope you'll have some time to review this. It's a blocker with RN 0.49. Thanks

"onDidClearAllBookmarksEmitter": {},
"onDidAddBookmarkEmitter": {},
"onDidRemoveBookmarkEmitter": {},
"onDidUpdateBookmarkEmitter": {},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this file?

# yarn lockfile v1


asap@~2.0.3:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree about removing this one. I use yarn, it's gaining popularity, I think it's better than npm and it's a drop-in replacement. Doesn't hurt to have the file, can be ignored if not using.

@chirag04
Copy link
Owner

just 2 nits and we can ship this. ideally we switch everything to es6 classes but it's fine for now

@fungilation
Copy link
Author

@chirag04 how about you make the call for what you want to merge. Merge this and then you can delete "offending" files as you wish.

@jeremyeaton89
Copy link

Can either this PR or #32 possibly get merged soon, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace React.createClass with createReactClass (react 15.5+)
5 participants