[2단계] 홍석주 미션 제출합니다 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somefood
commented
Aug 25, 2024
Comment on lines
+11
to
+16
| const ALL = '전체'; | ||
| const [category, setCategory] = useState(ALL); | ||
| const filteredRestaurants = category === ALL | ||
| ? restaurants | ||
| : restaurants.filter(restaurant => restaurant.category === category); | ||
|
|
There was a problem hiding this comment.
현재 App.jsx에 레스토랑 목록을 필터링하고 있는데, 비슷한 요구조건이 늘어나면 App.jsx가 지저분해질거 같은데, 이럴때는 어떤식으로 분리하는지 궁금합니다!
Comment on lines
+10
to
+21
| const categoryImages = { | ||
| '한식': categoryKorean, | ||
| '일식': categoryJapanese, | ||
| '중식': categoryChinese, | ||
| '양식': categoryWestern, | ||
| '아시안': categoryAsian, | ||
| '기타': categoryEtc | ||
| } | ||
|
|
||
| function getImage(category) { | ||
| return categoryImages[category]; | ||
| } |
There was a problem hiding this comment.
RestaurantList.jsx에서 각 카테고리마다 이미지 경로를 전달해주기 categoryImages 객체를 만들고 함수로 갖고 오게끔 처리했습니다. db.json에 url을 추가할까다가 최대한 건들지 않기 위해 위의 방식을 취했는데, 멘토님이라면 어떤식으로 처리하셨을지 궁금합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요.
2단계 미션 진행해보았습니다. 예제들을 찾아가면서 어렵지 않게 해결은 한 거 같습니다.
아래와 같이 완료해서 PR 드립니다.
고민사항