Skip to content
This repository has been archived by the owner on Jan 18, 2020. It is now read-only.

DCO & Lots of other stuff

Compare
Choose a tag to compare
@bruth bruth released this 13 Mar 20:15
· 217 commits to master since this release

In an effort to make the contributing to Avocado more transparent and safer for all, a Developer Certificate of Origin (DCO) has been added to the CONTRIBUTING.md. As a contributor, this certifies that you are legally allowed to contribute the code submitted as patches (in pull requests or otherwise).

This requires that all contributors to the repository now sign off their commits using the git commit --signoff (or -s for short). A script has been added to the Travis-CI config to check for the presence of the Signed-off-by: line. If any commit does not contain this, the build will error which will prevent core contributors from merging your code.

Features

PR #181 introduces four new optional fields on the DataField model. These are names of fields on the instance's model that are supplementary to the base field denoted byfield_name:

  • label_field_name
  • order_field_name
  • search_field_name
  • code_field_name

The model field object can be accessed through the corresponding datafield property (without the _name suffix). This feature supersedes the need for direct integration of the Lexicon and ObjectSet classes in the DataField API since the supplementary fields can now be set explicitly. Detection of these types will be removed in 2.4, however the detection in the avocado init will remain for now.

  • The DataConcept.type and DataField.type fields have been added to lay the foundation for refactoring how fields and concepts behave. Read more here #88
  • The DataField API now supports making use of pre-defined choices on the field instance (#157)

Enhancements

  • Parent categories are now included in the search index for fields and concepts (#142)
  • Categories can be auto-created during an avocado init call when the --categories flag is passed
    • Fields and concepts that are created will be associated with the category which is named after the associated model.
  • The Registry.register function can now be used as a decorator when registering classes or instances (#95)
  • The parent category of field and concepts are now included in the free-text search index (#142)
  • Categories can now be optionally created during an avocado init call by passing the --categories flag

Bugs

  • Fixed hard-coded label field name for objectset-based models
  • Fixed condition where revision data is null and causes an error during creating a diff
  • The published field is now correctly exposed and editable from the DataCategory admin list view (#196)
  • Query sharing now use a case-insensitive lookup on email addresses (#197)
  • Fixed an issue when metadata migrations would fail due to a schema dependency (#185)
    • This now includes a depends_on attribute with the latest Avocado migration