This repository has been archived by the owner on May 11, 2021. It is now read-only.
WORK IN PROGRESS -- Add support for async requests #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting this to default to false for now until model and UI support for async requests has been added Signed-off-by: Don Naegely <[email protected]>
This PR adds a setting to Cilantro that will choose whether synchronous or asycnhronous endpoints are used. The setting also controls which type of collections and UI elements are used as there can be big differences in behavior between the synchronous and asynchronous versions. The async collections and UI elements are stubbed out here for completeness and will be implemented in upcomin work. Signed-off-by: Don Naegely <[email protected]>
|
Closing this since #693 proposes moving entirely to the new async endpoints. The overhead should be minimal in the normal workflows(probably just 1 extra request in most cases). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bruth
I'm still working on the implementation of the async models and async UI elements so I just put stubs in here to keep the diff to a minimum for review. Wanted to get feedback on this approach for selecting different models and UI elements while I work on the async implementations themselves.
More updates to follow but if you could take a look at this in the meantime, I'd like to get the approach for branching on request types locked in. Note, it assumes the presence of async endpoints as proposed in chop-dbhi/serrano#284.
Signed-off-by: Don Naegely [email protected]