-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CameraInfo publisher. #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much. Your implementation looks correct.
I have proposed some changes in initialization, assignment, and variable names. Please consider to apply these. Please feel free to comment anything on my suggestions.
Co-authored-by: Yuki Onishi <[email protected]>
Co-authored-by: Yuki Onishi <[email protected]>
Co-authored-by: Yuki Onishi <[email protected]>
Co-authored-by: Yuki Onishi <[email protected]>
Thank you for checking. I don't think there is any problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I also verified this PR works well. Thanks a lot!
Add CameraInfo publisher.
related to #11.