Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CameraInfo publisher. #13

Merged
merged 5 commits into from
Jun 30, 2023

Conversation

Hiroaki-Masuzawa
Copy link
Contributor

Add CameraInfo publisher.

related to #11.

Copy link
Member

@ssr-yuki ssr-yuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much. Your implementation looks correct.

I have proposed some changes in initialization, assignment, and variable names. Please consider to apply these. Please feel free to comment anything on my suggestions.

src/plugin/BodyROSItem.cpp Outdated Show resolved Hide resolved
src/plugin/BodyROSItem.cpp Outdated Show resolved Hide resolved
src/plugin/BodyROSItem.cpp Outdated Show resolved Hide resolved
src/plugin/BodyROSItem.cpp Outdated Show resolved Hide resolved
@Hiroaki-Masuzawa
Copy link
Contributor Author

Hiroaki-Masuzawa commented Jun 26, 2023

Thank you for checking. I don't think there is any problem.

Copy link
Member

@ssr-yuki ssr-yuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I also verified this PR works well. Thanks a lot!

@ssr-yuki ssr-yuki merged commit 44902d9 into choreonoid:master Jun 30, 2023
@Hiroaki-Masuzawa Hiroaki-Masuzawa deleted the add_camerainfo branch July 6, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants