Merge pull request #1 from mrnugget/patch-1

Cache modulo operator in New
chr4 · Aug 6, 2014 · 4bd7451 · 4bd7451
2 parents 5b429c8 + d0f5a8f
commit 4bd7451
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pwgen.go b/pwgen.go
@@ -10,9 +10,11 @@ const chars = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_-?
 // New() generates a random string of the given length
 func New(length int) string {
 	var bytes = make([]byte, length)
+	var op = byte(len(chars))
+
 	rand.Read(bytes)
 	for i, b := range bytes {
-		bytes[i] = chars[b%byte(len(chars))]
+		bytes[i] = chars[b%op]
 	}
 	return string(bytes)
 }