Bad stdout #12
Open
Bad stdout #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot defined, the default value will be returned
…ot defined, the default value will be returned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reason for this fix is slightly complicated :
when Running IDA Pro with and ipython plugin , ipython calls get_terminal_size when handling certain exceptions.
the probelm is that IDAPythonStdOut doesn't have an attribute fileno.
AttributeError is raised and not caught , and the iPython kernel crashes.
I think it makes sense to catch it here and return the default values .
would help with other cases where the stdout object is weird (even if it's not very common).