Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Descriptor support to enable taproot wallets #271

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rage-proof
Copy link
Contributor

Hi,

I just wanted to add add the descriptor and taproot support for eps.
But then it let to more changes as intended that were needed. So I let this PR here and you can use it for later, because it works.

The problem is the legacy wallet is not able to handle taproot addresses.
wallet options:
legacy(berkley) - no importdescriptors, no taproot-addresses in general
new(sqlite) - no importmulti, no importaddresses

This leads to the conclusion that the use of the new-descriptor wallet is mandatory and comes with some obstacles:

  • a new wallet needs to be created explicitly with descriptor = true (from v23.0 it is standard)
  • the whole wallet needs to be rescanned
  • the Bitcoin Core version must be >= v22.0 (I guess)
  • labels dont work anymore in ranged descriptors, therefore I removed it

Because of having a current version of Core + creating a new wallet it's a bit much effort for an update.
Maybe the rpc upgradewallet is an option to keep the effort low.

rage-proof added 8 commits May 23, 2022 12:17
This make it possible to import descriptors including taproot(tr). Some other functions don't work anymore with the new wallet, e.g. import addresses, is_wachonly. Hence use replacement functions in those cases.
…y are used for xpubs. Therefore remove the label also form the imported single addresses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant