Remove unused BIP32 functions (pybitcointools) #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escend} All of those functions were introduced in the first commit, but never used, i.e. they can be removed. The change can be easily verified with the following commands: $ git grep bip32_privtopub $ git grep bip32_master_key $ git grep bip32_bin_extract_key $ git grep bip32_descend
After the previous commit, these functions are not used anymore. The change can be easily verified with the following commands: $ git grep raw_bip32_privtopub $ git grep bip32_ckd $ git grep bip32_extract_key
After the previous commit, this function is not used anymore. The change can be easily verified via: $ git grep raw_bip32_ckd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another step towards getting rid of unused functions from the pybitcointools library which was imported in the first commit. Note that the changes are deliberately kept minimal and are divided up into multiple commit in order to make review trivial; at each commit, searching the removed function in the code-base via executing
git grep funcnameverifies that the function is not directly called anymore (see also commit messages).