Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing infrastructure #4

Merged
merged 15 commits into from
Jun 4, 2017
Merged

Testing infrastructure #4

merged 15 commits into from
Jun 4, 2017

Conversation

chris-erickson
Copy link
Owner

@chris-erickson chris-erickson commented Jun 4, 2017

  • Adds support for pytest
  • Adds CircleCI for continuous integration testing
  • Adds Coveralls for code coverage reporting (doesn't run unless tests pass, but this is not made clear anywhere)
  • Adds Code Climate for checking the "quality" of the code. This actually requires no integration code-side, just setting up an account at codeclimate.com
  • Adds a build status badges in the README
  • Fixes some things like project naming
  • Comments out some test code, which should be removed once it's confirmed that's correct. This really needs to be removed or addressed, but it's just too early to do so.

The result of these is a couple status checks at the end of the pull request. This doesn't add immediate value to the code but over the years I have found that these checks can provide valuable insight and encouragement to get the code right. Countless times I and others have said I'll come back and fix this soon, never again to return.

screen shot 2017-06-04 at 10 05 52 am

On the project homepage we get:

screen shot 2017-06-04 at 10 11 37 am

Part of this project is building a "test" Django project so that I can develop on the JSON feed, and use it the way a typical user would (pip install, etc). Eventually will likely need a sample project for tests, which could also help illustrate how to use the tool.

One small point - I'll be doing a squash and merge for most PR's. This one is particularly fitting, as it won't load the master branch with 15 garbage commits where I was fighting with the CI system. The result will be a single merge commit with all 15 collapsed into it.

Resolves #5 and resolves #6

@chris-erickson chris-erickson force-pushed the testing-infrastructure branch 2 times, most recently from f37fac5 to 2917b4d Compare June 4, 2017 14:05
@chris-erickson chris-erickson force-pushed the testing-infrastructure branch from 2917b4d to 5713991 Compare June 4, 2017 14:06
@chris-erickson chris-erickson merged commit 4a1d284 into master Jun 4, 2017
@chris-erickson chris-erickson deleted the testing-infrastructure branch June 4, 2017 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate with code coverage service Integrate with a CI/CD service for running tests
1 participant