Apply order_required on view_that_asks_for_money #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This view needs an order to work properly, otherwise it will cause an AttributeError in the shop API when trying to get the order total via get_order_total. Applying the order_required decorator fixes this by making sure the client is redirected to the cart when there is no order on the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Chris,
what do you think about this change? It fixes an issue I have when clients are randomly hitting the view_that_asks_for_money URL without having created an order before. The main drawback I see is that it introduces a hard depdency on two functions in django-shop. Would you be ok with merging it, or do you think the dependency should be avoided, or do you have other objections?