upgrade to servant-0.5 and purescript-7.5.3. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't believe Anchor is still using this, and no-one who's worked on it still has a commit bit. If others are still using it, perhaps a fork would make sense? |
| where | ||
| purs = T.unlines | ||
| [ "module " <> (settings ^. utilModuleName) <> " where" | ||
| , "foreign import encodeURIComponent :: String -> String" |
There was a problem hiding this comment.
Maybe this could go into purescript-globals?
|
I concur, Anchor is highly unlikely to maintain this in the future, nor is the original author. I'll poke the servant people to see if they'd like to adopt the codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hei there, not sure if you are still using this, but I plowed through the code a little and made it compile with newer dependencies. For once, it now uses purescript-affjax instead of js inlines.
This might arguably be more useful than the current head, but it is not very mature. I haven't touched the demos and the README a lot, and I would like to use a more solid approach to constructing the code than throwing around strings. (Btw, I noticed that the tests will not fail if the generated code contains parse errors, and I just realize I haven't compiled the generated code myself yet.)
Anyway, here you go. Hope you like it.