Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to be backward compatible #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Jan 19, 2017

No description provided.

@ghost
Copy link
Author

ghost commented Jan 19, 2017

I'm not sure though if we shouldn't first check for cv2 instead of cv but also I don't know if there is an older cv2 which was working with the older engine.py but now with the newer opencv engine it doesn't work anymore?! (Also is travis using opencv2 or opencv3?)

@ghost
Copy link
Author

ghost commented Jan 19, 2017

I see that there is really an cv2 for opencv2 .. so unsure how to handle that really

@ghost
Copy link
Author

ghost commented Jan 19, 2017

tested now, opencv2.4 works with the engine_cv3 without a glitch.. so if I recall this, I would probably remove the engine.py and replace it with the engine_cv3.py or is there still a need for the old cv C interface?

@ghost
Copy link
Author

ghost commented Jan 19, 2017

2.3 beta

June, 2011

* python
Now there are 2 extension modules: cv and cv2. cv2 includes wrappers for OpenCV 2.x functionality. opencv/samples/python2 contain a few samples demonstrating cv2 in use.

so I think it is quiet okay to say, that we don't want to keep cv anymore, right?

@christianjgreen
Copy link
Owner

The cv interface (C api) was officially deprecated about two years ago. It would be best to be compliant and remove the old engine.

@christianjgreen
Copy link
Owner

Have you been able to get a working travis build with it?

@christianjgreen
Copy link
Owner

I believe I found a working pre-compiled package. I'll be using https://github.com/skvark/opencv-python for testing.

@ghost
Copy link
Author

ghost commented Jan 19, 2017

yeah the opencv-python thing is what I use as well, but this will always have the latest OpenCV version built-in .. so if you want to test for OpenCV 2.4 or any other in OpenCV 3.x except the latest stable, it won't really help.. so it depends what you think you want to achieve with the testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants