Skip to content

Commit

Permalink
Update the README with the correct build command and remove the icon …
Browse files Browse the repository at this point in the history
…override
  • Loading branch information
christianrowlands committed Mar 25, 2024
1 parent 6bdabbd commit 39ca513
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ modified. Conversations.im is an outstanding app so hats off to Daniel Gultsch!

To build a development debug version of Ninja Chat, you can use the command:
```
./gradlew assembleConversationsFreeSystemDebug
./gradlew assembleConversationsFreeDebug
```

To build and install the apk onto a connected device us the command:
```
./gradlew installConversationsFreeSystemDebug
./gradlew installConversationsFreeDebug
```

### Release
Expand All @@ -45,13 +45,12 @@ keystore.alias=

Then, build the release bundle using the following command
```
./gradlew bundleConversationsFreeSystemRelease
./gradlew bundleConversationsFreeRelease
```

There is also a GitLab CI/CD job setup to build the release APK and bundle.

----- Everything that follows in this README is from the original Conversations.im repo. -----
>>>>>>> ninja-master

## Design principles

Expand Down
2 changes: 1 addition & 1 deletion src/conversations/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools">

<application tools:replace="android:icon" android:icon="@mipmap/new_launcher">
<application>
<activity
android:name=".ui.ManageAccountActivity"
android:label="@string/title_activity_manage_accounts"
Expand Down

0 comments on commit 39ca513

Please sign in to comment.